Add Seek fallback for zip files
#2320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
added
bug
charliermarsh
force-pushed
the
charlie/data-descriptors
branch
2 times, most recently
from
88024f5 to
a608a9d
Compare
|
Somewhat torn on merging this. It's good behavior but it does add complexity, and |
charliermarsh
force-pushed
the
charlie/data-descriptors
branch
3 times, most recently
from
ff9a92b to
bd727ba
Compare
|
Eh, ultimately, this is a good thing to do. |
|
All these Windows tests are randomly overflowing their stacks is confusing to me. This shouldn't have changed the stack at all? |
charliermarsh
force-pushed
the
charlie/data-descriptors
branch
from
bd727ba to
3eaca9b
Compare
charliermarsh
added a commit
that referenced
this pull request
Mar 10, 2024
## Summary Improves consistency and helps with the kinds of failures seen in #2320.
charliermarsh
force-pushed
the
charlie/data-descriptors
branch
from
3eaca9b to
6faddd2
Compare
Every local variable increases the stack frame size 😭 |
|
Nooooo |
|
It must be so marginal |
|
debug is just super inefficient with stack space, this never happens on release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some zip files can't be streamed; in particular,
rs-async-zipdoesn't support data descriptors right now (though it may in the future). This PR adds a fallback path for such zips that downloads the entire zip file to disk, then unzips it from disk (which gives usSeek).Closes #2216.
Test Plan
cargo run pip install --extra-index-url https://buf.build/gen/python hashb_foxglove_protocolbuffers_python==25.3.0.1.20240226043130+465630478360 --force-reinstall -n